[core] Use rootProps instead of options in Grid components except for classes #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
changed the title
flaviendelangle
commented
Jul 26, 2021
flaviendelangle
added
the
internal
flaviendelangle
requested review from
DanailH,
m4theushw and
oliviertassinari
and removed request for
m4theushw
DanailH
reviewed
Jul 27, 2021
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
2 tasks
DanailH
reviewed
Jul 30, 2021
| import * as React from 'react'; | ||
| import { GridRootPropsContext } from '../../context/GridRootPropsContext'; | ||
|
|
||
| export const useGridRootProps = () => { |
Member
There was a problem hiding this comment.
I think that is better. I added @m4theushw but other than that I'm ok with the change.
DanailH
approved these changes
Aug 4, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step for migrating away from
options